lkml.org 
[lkml]   [2006]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 23/35] Unionfs: Main module functions

>+++ b/fs/unionfs/main.c
>+static int init_debug = 0;
>+module_param_named(debug, init_debug, int, S_IRUGO);
>+MODULE_PARM_DESC(debug, "Initial Unionfs debug value.");

I think there is not anything that forbids it being S_IRUGO | S_IWUSR.


>+
>+static int __init init_unionfs_fs(void)
>+{
>+ int err;
>+ printk("Registering unionfs " UNIONFS_VERSION "\n");
>+
>+ if ((err = init_filldir_cache()))
>+ goto out;
>+ if ((err = init_inode_cache()))
>+ goto out;
>+ if ((err = init_dentry_cache()))
>+ goto out;
>+ if ((err = init_sioq()))
>+ goto out;
>+ err = register_filesystem(&unionfs_fs_type);
>+out:
>+ if (err) {
>+ fin_sioq();
>+ destroy_filldir_cache();
>+ destroy_inode_cache();
>+ destroy_dentry_cache();
>+ }
>+ return err;
>+}
>+static void __exit exit_unionfs_fs(void)
>+{

There's that missing white line again :^)

>+ fin_sioq();
>+ destroy_filldir_cache();
>+ destroy_inode_cache();
>+ destroy_dentry_cache();
>+ unregister_filesystem(&unionfs_fs_type);
>+ printk("Completed unionfs module unload.\n");
>+}
>+
>+MODULE_AUTHOR("Erez Zadok, Filesystems and Storage Lab, Stony Brook University"
>+ " (http://www.fsl.cs.sunysb.edu)");
>+MODULE_DESCRIPTION("Unionfs " UNIONFS_VERSION
>+ " (http://www.unionfs.org)");
>+MODULE_LICENSE("GPL");
>+
>+module_init(init_unionfs_fs);
>+module_exit(exit_unionfs_fs);

Like with sioq, unionfs_init/unionfs_exit should suffice.


-`J'
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-05 22:43    [W:0.246 / U:3.036 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site