lkml.org 
[lkml]   [2006]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch 2/12] IPMI: remove interface number limits
Andrew Morton wrote:
> On Fri, 1 Dec 2006 22:24:22 -0600
> Corey Minyard <minyard@acm.org> wrote:
>
>
>> This patch removes the arbitrary limit of number of IPMI interfaces.
>> This has been tested with 8 interfaces.
>>
>> Signed-off-by: Corey Minyard <minyard@acm.org>
>> Cc: Carol Hebert <cah@us.ibm.com>
>>
>> ..
>>
>> +struct watcher_entry {
>> + struct list_head link;
>> + int intf_num;
>> +};
>> +
>> int ipmi_smi_watcher_register(struct ipmi_smi_watcher *watcher)
>> {
>> - int i;
>> - unsigned long flags;
>> + ipmi_smi_t intf;
>> + struct list_head to_deliver = LIST_HEAD_INIT(to_deliver);
>> + struct watcher_entry *e, *e2;
>> +
>> + mutex_lock(&ipmi_interfaces_mutex);
>> +
>> + list_for_each_entry_rcu(intf, &ipmi_interfaces, link) {
>> + if (intf->intf_num == -1)
>> + continue;
>> + e = kmalloc(sizeof(*e), GFP_KERNEL);
>> + if (!e)
>> + goto out_err;
>>
>
> You miss a mutex_unlock(&ipmi_interfaces_mutex) here
>
This is actually fixed in patch 4 (ipmi-system-interface-hotplug.patch)

-Corey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-05 16:45    [W:0.046 / U:5.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site