[lkml]   [2006]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff
Randy Dunlap wrote:
> Randy Dunlap wrote:
>> Bela Lubkin wrote:
>>> Andrew Morton wrote:
>>>>> Sometime, please go through the IPMI code looking for all these
>>>>> statically-allocated things which are initialised to 0 or NULL and
>>>>> remove
>>>>> all those intialisations? They're unneeded, they increase the
>>>>> vmlinux
>>>>> image size and there are quite a number of them. Thanks.
>>> Randy Dunlop replied:
>>>> I was just about to send that patch. Here it is,
>>>> on top of the series-of-12.
>>> ...
>>>> -static int bt_debug = BT_DEBUG_OFF;
>>>> +static int bt_debug;
>>> Is it wise to significantly degrade code readability to work around
>>> a minor
>>> compiler / linker bug?
>> Is that the only one that is a problem?
>> I don't think it's a problem. We *know* that static data areas
>> are init to 0. Everything depends on that. If that didn't work
>> it would all break.
>> I could say that it's a nice coincidence that BT_DEBUG_OFF == 0,
>> but I think that it's more than coincidence.
> It's Corey's decision. However, while code readability is also very
> important to me, I disagree with "significantly" above.
I think the optimizations are probably important enough that this should
be done. Let's take Randy's patch and I will add a comment to
BT_DEBUG_OFF that says that the value must be zero to correspond to
the default uninitialized value.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-12-05 16:45    [W:0.046 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site