lkml.org 
[lkml]   [2006]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [-mm patch] sched remove lb_stopbalance counter
Date
Ingo Molnar wrote on Tuesday, December 05, 2006 7:32 AM
> * Chen, Kenneth W <kenneth.w.chen@intel.com> wrote:
> > in -mm tree: I would like to revert the change on adding
> > lb_stopbalance counter. This count can be calculated by: lb_balanced
> > - lb_nobusyg - lb_nobusyq. There is no need to create gazillion
> > counters while we can derive the value. I'm more of against changing
> > sched-stat format unless it is absolutely necessary as all user land
> > tool parsing /proc/schedstat needs to be updated and it's a real pain
> > trying to keep multiple versions of it.
> >
> > Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
>
> Acked-by: Ingo Molnar <mingo@elte.hu>
>
> but, please:
>
> > -#define SCHEDSTAT_VERSION 13
> > +#define SCHEDSTAT_VERSION 12
>
> change this to 14 instead. Versions should only go upwards, even if we
> revert to an earlier output format.

Really? sched-decrease-number-of-load-balances.patch has not yet hit the
mainline and I think it's in -mm for only a couple of weeks. I'm trying
to back out the change after brief reviewing the patch.

- Ken
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-05 16:41    [W:0.036 / U:1.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site