lkml.org 
[lkml]   [2006]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [S390] cio: Make ccw_dev_id_is_equal() more robust.
From
Date
On Mon, 2006-12-04 at 10:23 -0500, Josef Sipek wrote:
> > diff -urpN linux-2.6/include/asm-s390/cio.h linux-2.6-patched/include/asm-s390/cio.h
> > --- linux-2.6/include/asm-s390/cio.h 2006-12-04 14:50:48.000000000 +0100
> > +++ linux-2.6-patched/include/asm-s390/cio.h 2006-12-04 14:51:00.000000000 +0100
> > @@ -278,7 +278,10 @@ struct ccw_dev_id {
> > static inline int ccw_dev_id_is_equal(struct ccw_dev_id *dev_id1,
> > struct ccw_dev_id *dev_id2)
> > {
> > - return !memcmp(dev_id1, dev_id2, sizeof(struct ccw_dev_id));
> > + if ((dev_id1->ssid == dev_id2->ssid) &&
> > + (dev_id1->devno == dev_id2->devno))
> > + return 1;
> > + return 0;
> > }
>
> Why not just:
>
> return ((dev_id1->ssid == ......) && (...));

Yes, why not. It would be a little bit shorter. The compiler probably
won't care and generate the same code..

--
blue skies,
Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-04 16:33    [from the cache]
©2003-2011 Jasper Spaans