Messages in this thread | | | Date | Sun, 3 Dec 2006 19:00:56 -0800 | From | Randy Dunlap <> | Subject | Re: [PATCH 9/12] IPMI: add pigeonpoint poweroff |
| |
On Sun, 03 Dec 2006 20:35:05 -0600 Corey Minyard wrote:
> Andrew Morton wrote: > > On Fri, 1 Dec 2006 22:37:46 -0600 > > Corey Minyard <minyard@acm.org> wrote: > > > > > >> +static void (*atca_oem_poweroff_hook)(ipmi_user_t user) = NULL; > >> > > > > Sometime, please go through the IPMI code looking for all these > > statically-allocated things which are initialised to 0 or NULL and remove > > all those intialisations? They're unneeded, they increase the vmlinux > > image size and there are quite a number of them. Thanks. > > > I'll do that, thanks, and I'll work on the other changes you suggest.
BTW, how about killing this comment or at least the email address part of it:
ipmi_bt_sm.c: * Author: Rocky Craig <first.last@hp.com>
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |