Messages in this thread | | | Date | Sun, 3 Dec 2006 13:26:10 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 7/12] IPMI: add poll delay |
| |
On Fri, 1 Dec 2006 22:35:20 -0600 Corey Minyard <minyard@acm.org> wrote:
> Make sure to delay a little in the IPMI poll routine so we can pass in > a timeout time and thus time things out. > > Signed-off-by: Corey Minyard <minyard@acm.org> > > Index: linux-2.6.19-rc6/drivers/char/ipmi/ipmi_si_intf.c > =================================================================== > --- linux-2.6.19-rc6.orig/drivers/char/ipmi/ipmi_si_intf.c > +++ linux-2.6.19-rc6/drivers/char/ipmi/ipmi_si_intf.c > @@ -807,7 +807,12 @@ static void poll(void *send_info) > { > struct smi_info *smi_info = send_info; > > - smi_event_handler(smi_info, 0); > + /* > + * Make sure there is some delay in the poll loop so we can > + * drive time forward and timeout things. > + */ > + udelay(10); > + smi_event_handler(smi_info, 10); > }
I don't understand what this patch is doing. It looks fishy. More details, please? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |