lkml.org 
[lkml]   [2006]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: Display class
    Date
    Hi,

    On Tuesday 05 December 2006 13:03, James Simmons wrote:
    > +int probe_edid(struct display_device *dev, void *data)
    > +{
    > +       struct fb_monspecs spec;
    > +       ssize_t size = 45;

    const ssize_t size = 45?

    > +
    > +       dev->name = kzalloc(size, GFP_KERNEL);

    Why do you need kzalloc here?

    > +       fb_edid_to_monspecs((unsigned char *) data, &spec);
    > +       strcpy(dev->name, spec.manufacturer);

    You seem to be overwriting dev->name in the very next line?

    > +       return snprintf(dev->name, size, "%s %s %s\n", spec.manufacturer, spec.monitor, spec.ascii);
    >

    Is result of snprintf interesting to the callers?

    --
    Dmitry
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-30 04:35    [W:0.023 / U:1.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site