Messages in this thread | | | Date | Thu, 28 Dec 2006 21:50:55 +0100 | From | Pavel Machek <> | Subject | Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers |
| |
Hi!
> > > From: Philipp Zabel <philipp.zabel@gmail.com> > > > > Missing s-o-b? > > Yes, still ... > > > > +static inline int gpio_direction_input(unsigned gpio) > > > +{ > > > + if (gpio > PXA_LAST_GPIO) > > > + return -EINVAL; > > > + pxa_gpio_mode(gpio | GPIO_IN); > > > +} > > > > Missing return 0? > > > > > +static inline int gpio_direction_output(unsigned gpio) > > > +{ > > > + if (gpio > PXA_LAST_GPIO) > > > + return -EINVAL; > > > + pxa_gpio_mode(gpio | GPIO_OUT); > > > +} > > > + > > > > And here? > > You're looking at about the oldest version of that patch. > Admittedly there were too many floating around...
I think I've looked at the newer ones, too, and this particular return was _not_ fixed. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |