lkml.org 
[lkml]   [2006]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [FSAIO][PATCH 7/8] Filesystem AIO read

    On Dec 28 2006 11:57, Christoph Hellwig wrote:
    >
    >> +
    >> + if ((error = __lock_page(page, current->io_wait))) {
    >> + goto readpage_error;
    >> + }
    >
    >This should be
    >
    > error = __lock_page(page, current->io_wait);
    > if (error)
    > goto readpage_error;

    That's effectively the same. Essentially a style thing, and I see if((err =
    xyz)) not being uncommon in the kernel tree.


    -`J'
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-28 17:35    [W:2.558 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site