lkml.org 
[lkml]   [2006]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 19/28] V4L/DVB (4991): Cafe_ccic.c: fix NULL dereference
    Date

    From: Adrian Bunk <bunk@stusta.de>

    We shouldn't dereference "cam" when we already know it's NULL.
    Spotted by the Coverity checker.

    Signed-off-by: Adrian Bunk <bunk@stusta.de>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
    ---

    drivers/media/video/cafe_ccic.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/media/video/cafe_ccic.c b/drivers/media/video/cafe_ccic.c
    index e347c7e..3083c80 100644
    --- a/drivers/media/video/cafe_ccic.c
    +++ b/drivers/media/video/cafe_ccic.c
    @@ -2166,7 +2166,7 @@ static void cafe_pci_remove(struct pci_d
    struct cafe_camera *cam = cafe_find_by_pdev(pdev);

    if (cam == NULL) {
    - cam_warn(cam, "pci_remove on unknown pdev %p\n", pdev);
    + printk(KERN_WARNING "pci_remove on unknown pdev %p\n", pdev);
    return;
    }
    mutex_lock(&cam->s_mutex);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-27 18:13    [W:0.020 / U:120.708 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site