lkml.org 
[lkml]   [2006]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 1/4] Add <linux/klog.h>
    Zack Weinberg wrote:
    > This patch introduces <linux/klog.h> with symbolic constants for the
    > various sys_syslog() opcodes, and changes all in-kernel references to
    > those opcodes to use the constants. The header is added to the set of
    > user/kernel interface headers.

    [...]

    > -/*
    > - * Commands to do_syslog:
    > +/**
    > + * do_syslog - operate on the log of kernel messages
    > + * @type: operation to perform
    > + * @buf: user-space buffer to copy data into
    > + * @len: number of bytes of space available at @buf
    > + *
    > + * See include/linux/klog.h for the command numbers passed as @type.
    > + * The @buf and @len parameters are used with the above meanings for
    > + * @type values %KLOG_READ, %KLOG_READ_HIST and %KLOG_READ_CLEAR_HIST.
    > + * @len is reused with a different meaning, and @buf ignored, for
    > + * %KLOG_SET_CONSOLE_LVL. Both @buf and @len are ignored for all
    > + * other @type values.
    > *
    > - * 0 -- Close the log. Currently a NOP.
    > - * 1 -- Open the log. Currently a NOP.
    > - * 2 -- Read from the log.
    > - * 3 -- Read all messages remaining in the ring buffer.
    > - * 4 -- Read and clear all messages remaining in the ring buffer
    > - * 5 -- Clear ring buffer.
    > - * 6 -- Disable printk's to console
    > - * 7 -- Enable printk's to console
    > - * 8 -- Set level of messages printed to console
    > - * 9 -- Return number of unread characters in the log buffer
    > - * 10 -- Return size of the log buffer
    > + * On failure, returns a negative errno code. On success, returns a
    > + * nonnegative integer whose meaning depends on @type.
    > */
    > int do_syslog(int type, char __user *buf, int len)
    > {
    > @@ -190,11 +192,11 @@

    That part looks good to me, and the kernel-doc hunks from
    "[patch 3/4] Refactor do_syslog interface"
    too, are:

    Acked-by: Vincent Legoll <vincent.legoll@gmail.com>

    thanks for handling that.

    --
    Vincent Legoll
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-28 00:29    [W:0.022 / U:62.668 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site