Messages in this thread Patch in this message | | | Subject | Re: BUG: scheduling while atomic - Linux 2.6.20-rc2-ga3d89517 | From | OGAWA Hirofumi <> | Date | Mon, 25 Dec 2006 01:58:09 +0900 |
| |
"Fabio Comolli" <fabio.comolli@gmail.com> writes:
> Just found this in syslog. It was during normal activity, about 6 > minutes after resume-from-ram. I never saw this before.
It seems someone missed to check PREEMPT_ACTIVE in __resched_legal(). Could you please test the following patch? -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> ---
kernel/sched.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff -puN kernel/sched.c~__resched_legal kernel/sched.c --- linux-2.6/kernel/sched.c~__resched_legal 2006-12-24 22:40:19.000000000 +0900 +++ linux-2.6-hirofumi/kernel/sched.c 2006-12-24 23:54:01.000000000 +0900 @@ -4619,10 +4619,11 @@ asmlinkage long sys_sched_yield(void) static inline int __resched_legal(int expected_preempt_count) { -#ifdef CONFIG_PREEMPT +#ifndef CONFIG_PREEMPT + expected_preempt_count = 0; +#endif if (unlikely(preempt_count() != expected_preempt_count)) return 0; -#endif if (unlikely(system_state != SYSTEM_RUNNING)) return 0; return 1; _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |