[lkml]   [2006]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch 2.6.20-rc1 6/6] S3C2410 GPIO wrappers
On Thu, Dec 21, 2006 at 11:33:11AM +0100, Arnaud Patard wrote:
> > +#include <asm/arch/irqs.h>
> imho, this is not needed. The user who will use irq will add it in his
> code anyway.
> > +#include <asm/arch/hardware.h>

This is a pet peave. _NO_ drivers should include either of these two
headers directly. Use asm/irq.h and asm/hardware.h instead. Audit your
code to ensure that you're including the right headers please.

I can see that I've got to do another sweep of the entire kernel code
to fix all these again.

Russell King
Linux kernel 2.6 ARM Linux -
maintainer of:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-12-23 12:45    [W:0.092 / U:1.904 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site