Messages in this thread | | | Date | Wed, 20 Dec 2006 13:12:24 +0100 | From | "Jesper Juhl" <> | Subject | Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3) |
| |
On 20/12/06, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > On Wed, 2006-12-20 at 12:39 +0100, Jesper Juhl wrote: > > Having the assignment of "ret = 1;" inside the loop seems a little > > pointless. Perhaps gcc can optimize it, but still, that assignment > > really only needs to happen once outside the loop. > > Sure, but I was hoping gcc was smart enough. Placing it outside the loop > would require an extra if stmt. Also the chance this loop will actually > be traversed more than once is _very_ small. >
allright - I just spotted it and thought I'd point it out :-)
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |