Messages in this thread | | | Date | Thu, 21 Dec 2006 01:11:12 +0100 | From | Francois Romieu <> | Subject | Re: Network drivers that don't suspend on interface down |
| |
Stephen Hemminger <shemminger@osdl.org> : [...] > IMHO: > When device is down, it should: > a) use as few resources as possible: > - not grab memory for buffers > - not assign IRQ unless it could get one > - turn off all power consumption possible > b) allow setting parameters like speed/duplex/autonegotiation, > ring buffers, ... with ethtool, and remember the state > c) not accept data coming in, and drop packets queued
<nit> Imho speed/duplex/autoneg is not the business of the device: they belong to the phy and it's up to it to decide if its state allows to set the requested parameters or not. </nit>
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |