Messages in this thread | | | Subject | Re: [stable][PATCH < 2.6.19] Fix data corruption with dm-crypt over RAID5 | From | Christophe Saout <> | Date | Sat, 02 Dec 2006 12:00:48 +0100 |
| |
Am Freitag, den 01.12.2006, 19:49 -0800 schrieb Chris Wright:
> * Christophe Saout (christophe@saout.de) wrote: > > Fix corruption issue with dm-crypt on top of software raid5. Cancelled > > readahead bio's that report no error, just have BIO_UPTODATE cleared > > were reported as successful reads to the higher layers (and leaving > > random content in the buffer cache). Already fixed in 2.6.19. > > I take it this is fixed a different way in 2.6.19? Mind clarifying the > difference?
It's more or less fixed the same way in 2.6.19. The function was reordered by Milan Broz to accommodate the changed write path (commit 8b004457168995f2ae2a35327f885183a9e74141):
> [PATCH] dm crypt: restructure for workqueue change > > Restructure part of the dm-crypt code in preparation for workqueue > changes. > > Use 'base_bio' or 'clone' variable names consistently throughout. No > functional changes are included in this patch.
"No functional changes" actually included the correct fix, accidental or not.
> Minor nit: introduces trailing whitespaces, cleaned it up locally.
Ouch, sorry.
[unhandled content-type:application/pgp-signature] | |