lkml.org 
[lkml]   [2006]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] hrtimers: add state tracking, fix
    Am 19.12.2006 20:56 schrieb Ingo Molnar:
    > thanks for the report - this made me review the hrtimer state engine
    > logic, and bingo, it indeed has a nasty typo! Could you try the fix
    > below, does it fix your problem? It might explain the crash you are
    > seeing, because the typo means we'd ignore HRTIMER_STATE_PENDING state
    > (which is rare but possible).

    Ok, the machine has been running for a couple of hours with that patch
    and so far hasn't frozen again. I'll watch it some more but it looks
    like your patch did indeed fix my problem.

    Thanks
    Tilman

    > -------------------------->
    > Subject: [patch] hrtimers: add state tracking, fix
    > From: Ingo Molnar <mingo@elte.hu>
    >
    > fix bug in hrtimer_is_queued(), introduced by a cleanup during
    > the recent refactoring.
    >
    > Signed-off-by: Ingo Molnar <mingo@elte.hu>
    > ---
    > kernel/hrtimer.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > Index: linux/kernel/hrtimer.c
    > ===================================================================
    > --- linux.orig/kernel/hrtimer.c
    > +++ linux/kernel/hrtimer.c
    > @@ -157,7 +157,7 @@ static void hrtimer_get_softirq_time(str
    > static inline int hrtimer_is_queued(struct hrtimer *timer)
    > {
    > return timer->state &
    > - (HRTIMER_STATE_ENQUEUED || HRTIMER_STATE_PENDING);
    > + (HRTIMER_STATE_ENQUEUED | HRTIMER_STATE_PENDING);
    > }
    >
    > /*

    --
    Tilman Schmidt E-Mail: tilman@imap.cc
    Bonn, Germany
    Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
    Ungeöffnet mindestens haltbar bis: (siehe Rückseite)

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2006-12-20 02:37    [W:0.038 / U:184.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site