Messages in this thread | | | Date | Tue, 19 Dec 2006 14:32:52 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] Add pci class code for SATA |
| |
Conke Hu wrote: > Add pci class code 0x0106 for SATA to pci_ids.h > > signed-off-by: conke.hu@gmail.com > -------------------- > --- linux-2.6.20-rc1/include/linux/pci_ids.h.orig 2006-12-20 > 01:58:30.000000000 +0800 > +++ linux-2.6.20-rc1/include/linux/pci_ids.h 2006-12-20 > 01:59:07.000000000 +0800 > @@ -15,6 +15,7 @@ > #define PCI_CLASS_STORAGE_FLOPPY 0x0102 > #define PCI_CLASS_STORAGE_IPI 0x0103 > #define PCI_CLASS_STORAGE_RAID 0x0104 > +#define PCI_CLASS_STORAGE_SATA 0x0106 > #define PCI_CLASS_STORAGE_SAS 0x0107 > #define PCI_CLASS_STORAGE_OTHER 0x0180
Two comments:
1) I think "_SATA" is an inaccurate description. It should be _AHCI AFAICS.
2) Typically we don't add constants unless they are used somewhere...
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |