Messages in this thread | | | Date | Tue, 19 Dec 2006 00:48:33 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH 2/5] Char: isicom, fix probe race |
| |
Andrew Morton wrote: > On Sat, 16 Dec 2006 02:09:48 +0100 (CET) > Jiri Slaby <jirislaby@gmail.com> wrote: > >> isicom, fix probe race >> >> Fix two race conditions in the probe function with mutex. >> >> ... >> >> static int __devinit isicom_probe(struct pci_dev *pdev, >> const struct pci_device_id *ent) >> { >> + static DEFINE_MUTEX(probe_lock); > > hm. How can isicom_probe() race with itself? Even with the dreaded > multithreaded-pci-probing? It's only called once, by a single thread. > > Confused.
Yeah, I'm a little bit too now. One of developers want me to do this some time ago and I did it without deep thinking about that. Now, I did it again and as you wrote, it's completely unreasonable. Please, throw it (char-isicom-fix-probe-race.patch) away.
thanks, -- http://www.fi.muni.cz/~xslaby/ Jiri Slaby faculty of informatics, masaryk university, brno, cz e-mail: jirislaby gmail com, gpg pubkey fingerprint: B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |