lkml.org 
[lkml]   [2006]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: sysfs file creation result nightmare
From
Date

> Beware that sysfs_remove_bin_file() will complain loudly if you later
> attempt to delete that file that was never created.

That's another problem... what is a driver that creates 15 files
supposed to do ? Have 15 booleans to remember which files where
successfully created and then test all of them on cleanup ? That sounds
like even more bloat to me...

What about making sysfs_remove_bin_file() not complain ? It's common
practice to have disposal things not complain ... like kfree(NULL), or
the changes done recently so that misc_deregister() can be called even
if misc_register() failed etc...

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-15 21:19    [W:0.164 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site