Messages in this thread | | | Subject | Re: sysfs file creation result nightmare | From | Benjamin Herrenschmidt <> | Date | Sat, 16 Dec 2006 07:16:13 +1100 |
| |
> Beware that sysfs_remove_bin_file() will complain loudly if you later > attempt to delete that file that was never created.
That's another problem... what is a driver that creates 15 files supposed to do ? Have 15 booleans to remember which files where successfully created and then test all of them on cleanup ? That sounds like even more bloat to me...
What about making sysfs_remove_bin_file() not complain ? It's common practice to have disposal things not complain ... like kfree(NULL), or the changes done recently so that misc_deregister() can be called even if misc_register() failed etc...
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |