lkml.org 
[lkml]   [2006]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 07/24] dm crypt: Fix data corruption with dm-crypt over RAID5
    2.6.18-stable review patch.  If anyone has any objections, please let us know.
    ------------------

    From: Christophe Saout <christophe@saout.de>

    Fix corruption issue with dm-crypt on top of software raid5. Cancelled
    readahead bio's that report no error, just have BIO_UPTODATE cleared
    were reported as successful reads to the higher layers (and leaving
    random content in the buffer cache). Already fixed in 2.6.19.

    Signed-off-by: Christophe Saout <christophe@saout.de>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    ---
    drivers/md/dm-crypt.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- linux-2.6.18.5.orig/drivers/md/dm-crypt.c
    +++ linux-2.6.18.5/drivers/md/dm-crypt.c
    @@ -717,13 +717,15 @@ static int crypt_endio(struct bio *bio,
    if (bio->bi_size)
    return 1;

    + if (!bio_flagged(bio, BIO_UPTODATE) && !error)
    + error = -EIO;
    +
    bio_put(bio);

    /*
    * successful reads are decrypted by the worker thread
    */
    - if ((bio_data_dir(bio) == READ)
    - && bio_flagged(bio, BIO_UPTODATE)) {
    + if (bio_data_dir(io->bio) == READ && !error) {
    kcryptd_queue_io(io);
    return 0;
    }
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-15 02:37    [W:0.021 / U:149.224 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site