lkml.org 
[lkml]   [2006]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 01/24] softmac: remove netif_tx_disable when scanning
    2.6.18-stable review patch.  If anyone has any objections, please let us know.
    ------------------

    From: Michael Buesch <mb@bu3sch.de>

    In the scan section of ieee80211softmac, network transmits are disabled.
    When SoftMAC re-enables transmits, it may override the wishes of a driver
    that may have very good reasons for disabling transmits. At least one failure
    in bcm43xx can be traced to this problem. In addition, several unexplained
    problems may arise from the unexpected enabling of transmits.

    Signed-off-by: Michael Buesch <mb@bu3sch.de>
    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    ---
    net/ieee80211/softmac/ieee80211softmac_scan.c | 2 --
    1 file changed, 2 deletions(-)

    --- linux-2.6.18.5.orig/net/ieee80211/softmac/ieee80211softmac_scan.c
    +++ linux-2.6.18.5/net/ieee80211/softmac/ieee80211softmac_scan.c
    @@ -47,7 +47,6 @@ ieee80211softmac_start_scan(struct ieee8
    sm->scanning = 1;
    spin_unlock_irqrestore(&sm->lock, flags);

    - netif_tx_disable(sm->ieee->dev);
    ret = sm->start_scan(sm->dev);
    if (ret) {
    spin_lock_irqsave(&sm->lock, flags);
    @@ -248,7 +247,6 @@ void ieee80211softmac_scan_finished(stru
    if (net)
    sm->set_channel(sm->dev, net->channel);
    }
    - netif_wake_queue(sm->ieee->dev);
    ieee80211softmac_call_events(sm, IEEE80211SOFTMAC_EVENT_SCAN_FINISHED, NULL);
    }
    EXPORT_SYMBOL_GPL(ieee80211softmac_scan_finished);
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-15 02:37    [W:4.046 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site