lkml.org 
[lkml]   [2006]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 2.6.19-git19] BUG due to bad argument to ieee80211softmac_assoc_work
On 12/13/06, Michael Bommarito <michael.bommarito@gmail.com> wrote:
> Sorry, realized I might not have been clear as to what I meant! The
> patch was attached to the bugzilla entry, but I'll attach it here as
> well. My description of the patch itself was really as complicated as
> it gets too (just two lines, switch (void*)mac to
> &mac->assoc.work.work in
> net/ieee80211/softmac/ieee80211softmac_assoc.c), just a small bug
> while somebody was rushing through the work/delayed_work changes.

--- net/ieee80211/softmac/ieee80211softmac_assoc.c 2006-12-13
11:23:03.000000000 -0500
+++ net/ieee80211/softmac/ieee80211softmac_assoc.c 2006-12-13
11:24:26.000000000 -0500
@@ -167,7 +167,7 @@
ieee80211softmac_assoc_notify_scan(struct net_device *dev, int
event_type, void *context)
{
struct ieee80211softmac_device *mac = ieee80211_priv(dev);
- ieee80211softmac_assoc_work((void*)mac);
+ ieee80211softmac_assoc_work(&mac->associnfo.work.work);
}

static void
@@ -177,7 +177,7 @@

switch (event_type) {
case IEEE80211SOFTMAC_EVENT_AUTHENTICATED:
- ieee80211softmac_assoc_work((void*)mac);
+ ieee80211softmac_assoc_work(&mac->associnfo.work.work);
break;
case IEEE80211SOFTMAC_EVENT_AUTH_FAILED:
case IEEE80211SOFTMAC_EVENT_AUTH_TIMEOUT:
Good catch, though it was already caught. See:

http://lkml.org/lkml/2006/12/12/46

...for (basically) the same patch.

But again, good catch :-).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-14 06:27    [W:0.038 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site