lkml.org 
[lkml]   [2006]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: CodingStyle: "kzalloc()" versus "kcalloc(1,...)"
On Thu, Dec 07, 2006 at 07:16:15PM -0500, Robert P. J. Day wrote:
>
> i just noticed that there are numerous invocations of kcalloc()
> where the hard-coded first arg of # elements is "1", which seems like
> an inappropriate use of kcalloc().
>
> the only rationale i can see is that kcalloc() guarantees that the
> memory will be set to zero, so i'm guessing that this form of
> kcalloc() was used before kzalloc() existed, or was used by folks who
> didn't know that kzalloc() existed.
>
> if a (zero-filled) single struct is being allocated, is it worth
> codifying that that allocation should use kzalloc() and not
> kcalloc(1,...)?

kcalloc() calls kzalloc(), so it doesn't matter at all which to use.

> rday

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-13 17:43    [W:0.485 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site