Messages in this thread | | | Date | Mon, 11 Dec 2006 20:34:54 +0100 (MET) | From | Jan Engelhardt <> | Subject | Re: 2.6.19-git13: uts banner changes break SLES9 (at least) |
| |
On Dec 11 2006 08:44, Linus Torvalds wrote: >> >> Please revert this change. > >Well, that "get_kernel_version" is definitely buggered, and should be >fixed. And we do want the new behaviour for /proc/version. > >So I don't think we should revert it, but we should: > > - strongly encourage "get_kernel_version" users to just stop using that > crap. Ask the build system for the version instead or something, don't > expect to dig it out of the binary (if you create an RPM for any other > package, you sure as _hell_ don't start doing strings on the binary and > try to figure out what the kernel is - you do it as part of the build) > >What crud. I'm even slightly inclined to just let SLES9 be broken, just to >let people know how unacceptable it is to look for strings in kernel >binaries. But sadly, I don't think the poor users should be penalized for >some idiotic SLES developers bad taste.
If you fix it now, it will anyhow only be fixed for >= 2.6.20, hence you don't break current/older SLES kernel builds.
-`J' -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |