lkml.org 
[lkml]   [2006]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -rt][RESEND] fix preempt hardirqs on OMAP

* Daniel Walker <dwalker@mvista.com> wrote:

> + /*
> + * Some boards will disable an interrupt when it
> + * sets IRQ_PENDING . So we have to remove the flag
> + * and re-enable to handle it.
> + */
> + if (desc->status & IRQ_PENDING) {
> + desc->status &= ~IRQ_PENDING;
> + if (desc->chip)
> + desc->chip->enable(irq);
> + goto restart;
> + }

what if the irq got disabled meanwhile? Also, chip->enable is a
compatibility method, not something we should use in a flow handler.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-11 20:11    [W:0.051 / U:2.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site