Messages in this thread | | | Date | Mon, 11 Dec 2006 08:05:56 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: Mark bitrevX() functions as const |
| |
On Mon, 11 Dec 2006, David Howells wrote: > > Mark the bit reversal functions as being const as they always return the same > output for any given input.
Well, we should mark the argument const too, no?
Does anythign actually improve from this? Also, we should actually use "__attribute_const__" instead (which works with other compilers), not the gcc'ism. That "__attribute__((const))" thing is a horrible syntax anyway (and has apparently slipped into <linux/log2.h> too - Damn.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |