Messages in this thread | | | Date | Sun, 10 Dec 2006 14:56:02 -0800 | From | Randy Dunlap <> | Subject | Re: [PATCH v3 13/13] Kconfig/Makefile |
| |
On Sun, 10 Dec 2006 16:39:16 -0600 Steve Wise wrote:
> drivers/infiniband/Kconfig | 1 + > drivers/infiniband/Makefile | 1 + > drivers/infiniband/hw/cxgb3/Kconfig | 27 +++++++++++++++++++++++++++ > drivers/infiniband/hw/cxgb3/Makefile | 12 ++++++++++++ > drivers/infiniband/hw/cxgb3/locking.txt | 25 +++++++++++++++++++++++++ > 5 files changed, 66 insertions(+), 0 deletions(-) > > diff --git a/drivers/infiniband/hw/cxgb3/Kconfig b/drivers/infiniband/hw/cxgb3/Kconfig > new file mode 100644 > index 0000000..84f0f6e > --- /dev/null > +++ b/drivers/infiniband/hw/cxgb3/Kconfig > @@ -0,0 +1,27 @@ > +config INFINIBAND_CXGB3 > + tristate "Chelsio RDMA Driver" > + depends on CHELSIO_T3 && INFINIBAND > + select GENERIC_ALLOCATOR > + ---help--- > + This is an iWARP/RDMA driver for the Chelsio T3 1GbE and > + 10GbE adapters. > + > + For general information about Chelsio and our products, visit > + our website at <http://www.chelsio.com>. > + > + For customer support, please visit our customer support page at > + <http://www.chelsio.com/support.htm>. > + > + Please send feedback to <linux-bugs@chelsio.com>. > + > + To compile this driver as a module, choose M here: the module > + will be called iw_cxgb3.
Please indent all of that the same amount. Kconfig help text should be indented 1 tab + 2 spaces, like the first 2 lines are.
> diff --git a/drivers/infiniband/hw/cxgb3/locking.txt b/drivers/infiniband/hw/cxgb3/locking.txt > new file mode 100644 > index 0000000..e5e9991 > --- /dev/null > +++ b/drivers/infiniband/hw/cxgb3/locking.txt > @@ -0,0 +1,25 @@ > +cq lock: > + - spin lock > + - used to synchronize the t3_cq > + > +qp lock: > + - spin lock > + - used to synchronize updates to the qp state, attrs, and the t3_wq. > + - touched on interrupt and process context > + > +rnicp lock: > + - spin lock > + - touched on interrupt and process context > + - used around lookup tables mapping CQID and QPID to a structure. > + - used also to bump the refcnt atomically with the lookup. > + > +poll: > + lock+disable on cq lock > + lock qp lock for each cqe that is polled around the call > + to cxio_poll_cq(). > + > +post: > + lock+disable qp lock > + > +global mutex iwch_mutex: > + used to maintain global device list.
Should be in Documentation/infiniband/. Docs go in the Documentation/ dir, not in drivers/ dir.
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |