lkml.org 
[lkml]   [2006]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG] commit 3c517a61, slab: better fallback allocation behavior
On Sun, 10 Dec 2006 12:49:07 -0800
Paul Jackson <pj@sgi.com> wrote:

> Good report - thanks.
>
> Christoph - fallback_alloc() can be called with interrupts off.
>
> I fixed the cpuset_zone_allowed() call from fallback_alloc() to avoid
> sleeping. Notice the __GFP_HARDWALL added in Linus's version, or the
> new function cpuset_zone_allowed_hardwall() in Andrew's version, all
> done in the last week.
>
> But apparently kmem_getpages() can also sleep, as it calls __alloc_pages().
>

This is lame. Please, always always test all new submissions with all the
nice kernel debugging options enabled.

They are summarised in Documentation/SubmitChecklist, along with a number
of other useful bug-prevention suggestions.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-10 23:17    [W:0.065 / U:1.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site