Messages in this thread | | | Date | Sun, 10 Dec 2006 22:49:54 +0100 | From | Folkert van Heusden <> | Subject | Re: strncpy optimalisation? (lib/string.c) |
| |
> > This one (tested in test-code seperate from kernel) works: > No it doesn't! > strncpy() guarantees that the entire destination buffer is written to. > If you call > strncpy(dest, "foo", 10000) > then you MUST write to 10000 bytes of memory, or your strncpy() is buggy. > Your patches basically turn strncpy() into strlcpy(). Don't do that. > They're separate functions for a reason.
Yes I saw that, didn't read your e-mail before I read Willy's message.
Can you please also have a look at my strlcpy patch?
Folkert van Heusden
-- www.vanheusden.com/recoverdm/ - got an unreadable cd with scratches? recoverdm might help you recovering data -------------------------------------------------------------------- Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |