Messages in this thread |  | | Date | Sun, 10 Dec 2006 14:05:07 -0800 | From | Mitchell Blank Jr <> | Subject | Re: strncpy optimalisation? (lib/string.c) |
| |
Folkert van Heusden wrote: > This one (tested in test-code seperate from kernel) works:
No it doesn't!
strncpy() guarantees that the entire destination buffer is written to. If you call strncpy(dest, "foo", 10000) then you MUST write to 10000 bytes of memory, or your strncpy() is buggy.
Your patches basically turn strncpy() into strlcpy(). Don't do that. They're separate functions for a reason.
-Mitch - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |