lkml.org 
[lkml]   [2006]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 29/36] sysfs: sysfs_write_file() writes zero terminated data
    Date
    From: Thomas Maier <balagi@justmail.de>

    since most of the files in sysfs are text files,
    it would be nice, if the "store" function called
    during sysfs_write_file() gets a zero terminated
    string / data.
    The current implementation seems not to ensure this.
    (But only if it is the first time the zeroed buffer
    page is allocated.)

    So the buffer can be scanned by sscanf() easily,
    for example.

    This patch simply sets a \0 char behind the
    data in buffer->page.

    Signed-off-by: Thomas Maier <balagi@justmail.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    fs/sysfs/file.c | 3 +++
    1 files changed, 3 insertions(+), 0 deletions(-)

    diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
    index 298303b..95c1651 100644
    --- a/fs/sysfs/file.c
    +++ b/fs/sysfs/file.c
    @@ -190,6 +190,9 @@ fill_write_buffer(struct sysfs_buffer *
    count = PAGE_SIZE - 1;
    error = copy_from_user(buffer->page,buf,count);
    buffer->needs_read_fill = 1;
    + /* if buf is assumed to contain a string, terminate it by \0,
    + so e.g. sscanf() can scan the string easily */
    + buffer->page[count] = 0;
    return error ? -EFAULT : count;
    }

    --
    1.4.4.1
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-02 00:29    [W:4.540 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site