lkml.org 
[lkml]   [2006]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos
Valdis.Kletnieks@vt.edu wrote:
> On Wed, 08 Nov 2006 16:15:46 CST, Corey Minyard said:
>
>> Ouch, I guess we've never had a system with these address types. Thanks.
>>
>
> If we never had a system with these address types..
>
>
>>> static unsigned char intf_mem_inw(struct si_sm_io *io, unsigned int offset)
>>> {
>>> return (readw((io->addr)+(offset * io->regspacing)) >> io->regshift)
>>> - && 0xff;
>>> + & 0xff;
>>> }
>>>
>
> Is this dead code that isn't called by anybody?
>
Well, not exactly. The SMBIOS or ACPI tables that report these interfaces
have various options for the size of the device registers. The driver
implements all the options, but there may or may not be systems with
every option available. But I can't exactly guess what is available in the
field.

-Corey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-09 15:47    [from the cache]
©2003-2011 Jasper Spaans