lkml.org 
[lkml]   [2006]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [linux-usb-devel] 2.6.19-rc5-mm1
    On Fri, 10 Nov 2006 00:39:46 +0100
    "C__dric Augonnet" <cedric.augonnet@gmail.com> wrote:

    > 2006/11/9, Andrew Morton <akpm@osdl.org>:
    >
    > >
    > > hm. Maybe it's the disk_sysfs_symlinks() changes.
    > >
    > > Could someone who can reproduce this please try this revert, on
    > > 2.6.19-rc2-mm2 through 2.6.19-rc5-mm1?
    > >
    > >
    > >
    > > fs/partitions/check.c | 5 +++--
    > > 1 files changed, 3 insertions(+), 2 deletions(-)
    > >
    > > diff -puN fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal fs/partitions/check.c
    > > --- a/fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal
    > > +++ a/fs/partitions/check.c
    > > @@ -416,7 +416,7 @@ static char *make_block_name(struct gend
    > >
    > > static int disk_sysfs_symlinks(struct gendisk *disk)
    > > {
    > > - struct device *target = disk->driverfs_dev;
    > > + struct device *target = get_device(disk->driverfs_dev);
    > > int err;
    > > char *disk_name = NULL;
    > >
    > > @@ -452,8 +452,9 @@ err_out_dev_link:
    > > sysfs_remove_link(&disk->kobj, "device");
    > > err_out_disk_name:
    > > kfree(disk_name);
    > > - }
    > > err_out:
    > > + put_device(target);
    > > + }
    > > return err;
    > > }
    > >
    > > _
    > >
    > > -
    > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > > the body of a message to majordomo@vger.kernel.org
    > > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > > Please read the FAQ at http://www.tux.org/lkml/
    > >
    >
    > Hi,
    >
    > This patch seems to be working : whereas i had the same oops as Mattia
    > each time I unplugged my USB external DD drive, now it does not happen
    > anymore.
    > Thank you very much for this one !
    >

    OK, thanks. I dropped the patch. So ide-cs will now start deadlocking
    again.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-10 01:15    [W:0.029 / U:0.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site