Messages in this thread | | | Date | Thu, 9 Nov 2006 17:00:03 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 2.6.19 5/5] fs: freeze_bdev with semaphore not mutex |
| |
Hi!
> > > Well, it looks like the interactions with dm add quite a bit of > > > complexity here. > > > > What about just fixing xfs (thou shall not write to disk when kernel > > threads are frozen), and getting rid of blockdev freezing? > > Well, first I must admit you were absolutely right being suspicious with > respect to this stuff.
(OTOH your patch found real bugs in suspend.c, so...)
> OTOH I have no idea _how_ we can tell xfs that the processes have been > frozen. Should we introduce a global flag for that or something?
I guess XFS should just do all the writes from process context, and refuse any writing when its threads are frozen... I actually still believe it is doing the right thing, because you can't really write to disk from timer. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |