Messages in this thread Patch in this message | | | From | "Chen, Kenneth W" <> | Subject | [patch] fix up generic csum_ipv6_magic function prototype | Date | Wed, 8 Nov 2006 18:02:06 -0800 |
| |
The generic version of csum_ipv6_magic has the len argument declared as __u16, while most arch dependent version declare it as __u32. After looking at the call site of this function, I come up to a conclusion that __u32 is a better match with the actual usage.
Hence, patch to change argument type for greater consistency.
Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
---
asm-m32r and asm-parisc both have it declared as __u16. I think it is a copy-n-paste error and needs to be fixed by arch maintainer, I hope.
--- ./include/net/ip6_checksum.h.orig 2006-11-08 18:49:50.000000000 -0800 +++ ./include/net/ip6_checksum.h 2006-11-08 18:50:04.000000000 -0800 @@ -36,7 +36,7 @@ static __inline__ unsigned short int csum_ipv6_magic(struct in6_addr *saddr, struct in6_addr *daddr, - __u16 len, + __u32 len, unsigned short proto, unsigned int csum) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |