Messages in this thread | | | Date | Wed, 8 Nov 2006 11:06:01 -0800 | From | Andrew Morton <> | Subject | Re: e1000: include <net/ip6_checksum.h> for IA64 |
| |
On Wed, 08 Nov 2006 09:48:35 -0800 Auke Kok <auke-jan.h.kok@intel.com> wrote:
> Here's a slightly better patch to fix ia64 not building atm.
fsvo "better".
> Jeff, please apply this to netdev-2.6#upstream instead of akpm's patch that I acked earlier. > > Of course, someone really should come up with an asm version for ia64 of the missing > function ;) > > Cheers, > > Auke > > --- > > e1000: include <net/ip6_checksum.h> for IA64 > > IA64 does not have an optimized asm version for ipv6 csum magic. Fall > back to generic implementation. > > Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com> > > diff --git a/drivers/net/e1000/e1000.h b/drivers/net/e1000/e1000.h > index f091042..26e7506 100644 > --- a/drivers/net/e1000/e1000.h > +++ b/drivers/net/e1000/e1000.h > @@ -61,6 +61,7 @@ > #include <linux/ip.h> > #ifdef NETIF_F_TSO6 > #include <linux/ipv6.h> > +#include <net/ip6_checksum.h> > #endif > #include <linux/tcp.h> > #include <linux/udp.h>
It is noxious of e1000 to do a #include <everything.h> from its driver-wide header file and I refused to be a party to such a thing!
Jeff probably won't be able to apply this because, like your other patches, it is space-stuffed. Then again, maybe git understands format=flowed, dunno. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |