lkml.org 
[lkml]   [2006]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 19/33] usb: auerswald free kill urb cleanup and memleak fix
    Date
    Hello,

    - usb_free_urb() cleanup
    - auerbuf_setup() memleak fix
    - usb_kill_urb() cleanup

    Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>

    --- linux-2.6.19-rc4-orig/drivers/usb/misc/auerswald.c 2006-11-06 17:08:20.000000000 +0100
    +++ linux-2.6.19-rc4/drivers/usb/misc/auerswald.c 2006-11-07 18:25:16.000000000 +0100
    @@ -704,9 +704,7 @@ static void auerbuf_free (pauerbuf_t bp)
    {
    kfree(bp->bufp);
    kfree(bp->dr);
    - if (bp->urbp) {
    - usb_free_urb(bp->urbp);
    - }
    + usb_free_urb(bp->urbp);
    kfree(bp);
    }

    @@ -780,7 +778,7 @@ static int auerbuf_setup (pauerbufctl_t

    bl_fail:/* not enough memory. Free allocated elements */
    dbg ("auerbuf_setup: no more memory");
    - kfree(bep);
    + auerbuf_free(bep);
    auerbuf_free_buffers (bcp);
    return -ENOMEM;
    }
    @@ -1155,8 +1153,7 @@ static void auerswald_int_release (pauer
    dbg ("auerswald_int_release");

    /* stop the int endpoint */
    - if (cp->inturbp)
    - usb_kill_urb (cp->inturbp);
    + usb_kill_urb (cp->inturbp);

    /* deallocate memory */
    auerswald_int_free (cp);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-11-08 15:47    [W:4.304 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site