lkml.org 
[lkml]   [2006]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode
    From
    Date
    Hi Arnd,
    > This seems broken. You have a constructor for newly allocated objects,
    but
    > there is no destructor and it seems that objects passed to
    > ehca_free_fw_ctrlblock are not guaranteed to be initialized either.
    > I'd simply move the memset into the alloc function and get rid of the
    > constructor here.
    Yep, I was not aware that ctor is not called for every
    kmem_cache_alloc(). Thx for pointing this out.
    Nam

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-06 10:59    [W:0.018 / U:31.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site