Messages in this thread Patch in this message | | | From | Mariusz Kozlowski <> | Subject | Re: [PATCH 2.6.19-rc4] usb auerswald possible memleak fix | Date | Tue, 7 Nov 2006 00:31:51 +0100 |
| |
Witam,
> Hello, > > There is possible memleak in auerbuf_setup(). Fix is to replace kfree() with auerbuf_free(). > An argument to usb_free_urb() does not need a check as usb_free_urb() already does that. Not sure if I should > send this in two separate patches. The patch is against 2.6.19-rc4 (not -mm).
As I posted the bigger usb_free_urb() patch in another mail this one should do only one thing which is to fix possible memory leak in auerbuf_setup().
Regards,
Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
diff -up linux-2.6.19-rc4-orig/drivers/usb/misc/auerswald.c linux-2.6.19-rc4/drivers/usb/misc/auerswald.c --- linux-2.6.19-rc4-orig/drivers/usb/misc/auerswald.c 2006-11-06 17:08:20.000000000 +0100 +++ linux-2.6.19-rc4/drivers/usb/misc/auerswald.c 2006-11-07 00:26:25.000000000 +0100 @@ -780,7 +780,7 @@ static int auerbuf_setup (pauerbufctl_t bl_fail:/* not enough memory. Free allocated elements */ dbg ("auerbuf_setup: no more memory"); - kfree(bep); + auerbuf_free (bep); auerbuf_free_buffers (bcp); return -ENOMEM; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |