lkml.org 
[lkml]   [2006]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + net-uninline-xfrm_selector_match.patch added to -mm tree
On Mon, 06 Nov 2006 14:38:31 -0800 (PST)
David Miller <davem@davemloft.net> wrote:

> From: akpm@osdl.org
> Date: Fri, 03 Nov 2006 11:34:12 -0800
>
> > Subject: net: uninline xfrm_selector_match()
> > From: Andrew Morton <akpm@osdl.org>
> >
> > Six callsites, huge.
> >
> > Cc: Arnaldo Carvalho de Melo <acme@mandriva.com>
> > Signed-off-by: Andrew Morton <akpm@osdl.org>
>
> You can't implement it like this :-)
>
> xfrm_user.c is a bad place to put the uninlined version because
> this can be built modular, whereas the callsites in places such
> as xfrm_policy.c will be built statically into the kernel.

I would have found that out when I got around to compiling it ;)

Where should the out-of-line function be placed, or should I just drop it?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-06 23:53    [W:0.074 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site