lkml.org 
[lkml]   [2006]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode
    Date
    On Sunday 05 November 2006 21:40, Hoang-Nam Nguyen wrote:

    > +/* constructor ctblk_cache */
    > +void ehca_ctblk_ctor(void *ptr, kmem_cache_t *cache, unsigned long flags)
    > +{
    > + memset(ptr, 0, EHCA_PAGESIZE);
    > +}
    > +
    > +void *ehca_alloc_fw_ctrlblock(void)
    > +{
    > + void *ret = kmem_cache_alloc(ctblk_cache, SLAB_KERNEL);
    > + if (!ret)
    > +  ehca_gen_err("Out of memory for ctblk");
    > + return ret;
    > +}
    > +
    > +void ehca_free_fw_ctrlblock(void *ptr)
    > +{
    > + if (ptr)
    > +  kmem_cache_free(ctblk_cache, ptr);
    > +

    This seems broken. You have a constructor for newly allocated objects, but
    there is no destructor and it seems that objects passed to
    ehca_free_fw_ctrlblock are not guaranteed to be initialized either.

    I'd simply move the memset into the alloc function and get rid of the
    constructor here.

    Arnd <><
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-06 00:49    [W:0.020 / U:0.792 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site