lkml.org 
[lkml]   [2006]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] i386: remove IOPL check on task switch
Linus Torvalds wrote:
> On Sat, 4 Nov 2006, Zachary Amsden wrote:
>
>> Ok, checking shows Linus put it back to stop NT leakage. This is correct, but
>> unlikely. Would be nice to avoid it unless absolutely necessary. Perhaps xor
>> eflags old and new and only set_system_eflags() if non-ALU bits have changed.
>>
>
> Not just NT. AC also leaked, and caused crashes in other programs (Wine)
> that didn't expect AC to be set and did unaligned accesses.

Yes, AC, NT, IOPL, ID are bad to leak. DF / TF / RF are impossible to
leak by privilege contract. SF, ZF, PF, OF, CF can be clobbered.

VM / VIF / VIP are dealt with in separate switch paths (although I have
witnessed a VIF leak once from a userspace process that managed to get
VIF set). These can't even be set with popf, and require iret to fix.

But 99% of the time, only SF / ZF / PF / OF / CF will be different, so
you can avoid the popf.

Zach
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-04 21:13    [W:0.185 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site