Messages in this thread | | | Date | Thu, 30 Nov 2006 11:19:34 +0100 | From | Nick Piggin <> | Subject | Re: [patch 1/3] mm: pagecache write deadlocks zerolength fix |
| |
On Thu, Nov 30, 2006 at 11:15:39AM +0100, Andreas Schwab wrote: > Nick Piggin <npiggin@suse.de> writes: > > > writev with a zero-length segment is a noop, and we shouldn't return EFAULT. > > AFAICS the callers of these functions never pass a zero length.
They can in the case of a zero length write. I had considered also doing this check in the caller, but I don't think it is too harmful to make the API a little more robust? But if you have another preference?
Thanks, Nick
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |