lkml.org 
[lkml]   [2006]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 3/3] fs: fix cont vs deadlock patches
On Fri, Dec 01, 2006 at 10:11:14AM +0900, OGAWA Hirofumi wrote:
> Nick Piggin <npiggin@suse.de> writes:
>
> > I would be happy if you come up with a quick fix, I'm just trying to
> > stamp out a few big bugs in mm. However I did prefer my way of moving
> > all the exapand code into generic_cont_expand, out of prepare_write, and
> > avoiding holding the target page locked while we're doing all the expand
> > work (strictly, you might be able to get away with this, but it is
> > fragile and ugly).
> >
> > AFAIKS, the only reason to use prepare_write is to avoid passing the
> > get_block into generic_cont_expand?
>
> IIRC, because generic_cont_expand is designed as really generic. It
> can also use for non moronic filesystem.
>
> In the case of reiserfs, it ->prepare_write might be necessary.

Yes I see :(

Well, maybe we should use your alternate patch, then.
I have a few questions on it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-01 03:07    [W:1.095 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site