lkml.org 
[lkml]   [2006]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tlclk: fix platform_device_register_simple() error check
On Mon, Nov 27, 2006 at 12:34:52PM -0800, Mark Gross wrote:
> >
> > tlclk_device = platform_device_register_simple("telco_clock",
> > -1, NULL, 0);
> > - if (!tlclk_device) {
> > + if (IS_ERR(tlclk_device)) {
> ok
>
> > printk(KERN_ERR "tlclk: platform_device_register failed.\n");
> > - ret = -EBUSY;
> > + ret = PTR_ERR(tlclk_device);
>
> I don't know about this but I could be wrong. Please convince me.

We expect platform_device_register_simple() returns proper errno as pointer
when it fails.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-28 07:19    [W:0.059 / U:60.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site