lkml.org 
[lkml]   [2006]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 8/12] ext4 balloc: fix off-by-one against grp_goal
    From
    Date

    Subject: ext2 balloc: fix off-by-one against grp_goal
    From: Hugh Dickins <hugh@veritas.com>

    grp_goal 0 is a genuine goal (unlike -1), so ext2_try_to_allocate_with_rsv
    should treat it as such.
    ------------------------------------------------------
    Sync up with ext2 reservation fix in ext4
    Signed-off-by: Mingming Cao <cmm@us.ibm.com>
    ---


    ---

    linux-2.6.19-rc5-cmm/fs/ext4/balloc.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff -puN fs/ext4/balloc.c~ext4-balloc-fix-off-by-one-against-grp_goal fs/ext4/balloc.c
    --- linux-2.6.19-rc5/fs/ext4/balloc.c~ext4-balloc-fix-off-by-one-against-grp_goal 2006-11-28 19:37:05.000000000 -0800
    +++ linux-2.6.19-rc5-cmm/fs/ext4/balloc.c 2006-11-28 19:37:05.000000000 -0800
    @@ -1288,7 +1288,7 @@ ext4_try_to_allocate_with_rsv(struct sup
    }
    /*
    * grp_goal is a group relative block number (if there is a goal)
    - * 0 < grp_goal < EXT4_BLOCKS_PER_GROUP(sb)
    + * 0 <= grp_goal < EXT4_BLOCKS_PER_GROUP(sb)
    * first block is a filesystem wide block number
    * first block is the block number of the first block in this group
    */
    @@ -1324,7 +1324,7 @@ ext4_try_to_allocate_with_rsv(struct sup
    if (!goal_in_my_reservation(&my_rsv->rsv_window,
    grp_goal, group, sb))
    grp_goal = -1;
    - } else if (grp_goal > 0) {
    + } else if (grp_goal >= 0) {
    int curr = my_rsv->rsv_end -
    (grp_goal + group_first_block) + 1;

    _


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-29 05:19    [W:4.131 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site