lkml.org 
[lkml]   [2006]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [-mm patch] drivers/mtd/nand/rtc_from4.c: use lib/bitrev.c
    On Tue, 28 Nov 2006 22:52:16 +0000
    David Woodhouse <dwmw2@infradead.org> wrote:

    > > I'll take that as an ack and shall merge this once
    > > crc32-replace-bitreverse-by-bitrev32.patch is merged ;)
    >
    > I assume the bitrev thing will be going in as soon as 2.6.19 is actually
    > released,

    It will take over a week after 2.6.19 - I prefer to wait until the git tree
    laggards^Wowners have merged before merging -mm stuff, so things land in
    appropriate order.

    > so there's no point in me reverting it from the mtd tree?

    Your call.

    I do have a fixlet against this patch:

    --- a/drivers/mtd/nand/rtc_from4.c~drivers-mtd-nand-rtc_from4c-use-lib-bitrevc-tidy
    +++ a/drivers/mtd/nand/rtc_from4.c
    @@ -357,7 +357,7 @@ static int rtc_from4_correct_data(struct
    /* Read the syndrom pattern from the FPGA and correct the bitorder */
    rs_ecc = (volatile unsigned short *)(rtc_from4_fio_base + RTC_FROM4_RS_ECC);
    for (i = 0; i < 8; i++) {
    - ecc[i] = byte_rev_table[(*rs_ecc) & 0xFF];
    + ecc[i] = bitrev8(*rs_ecc);
    rs_ecc++;
    }

    _

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-29 01:15    [W:4.132 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site