lkml.org 
[lkml]   [2006]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: mm/fremap.c(104): remark #593: variable "pte_val" was set but never used
On Mon, 27 Nov 2006, d binderman wrote:
>
> I just tried to compile Linux kernel 2.6.18.3 with the Intel C
> C compiler.
>
> The compiler said
>
> mm/fremap.c(104): remark #593: variable "pte_val" was set but never used
>
> The source code is
>
> pte_t pte_val;
>
> I have checked the source code and I agree with the compiler.
> Suggest delete local variable.

You're right, thank you, here's a patch...


[PATCH] kill install_file_pte's pte_val

David Binderman and his Intel C compiler rightly observe that
install_file_pte no longer has any use for its pte_val.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---

mm/fremap.c | 2 --
1 file changed, 2 deletions(-)

--- 2.6.19-rc6/mm/fremap.c 2006-11-16 08:22:25.000000000 +0000
+++ linux/mm/fremap.c 2006-11-28 17:50:47.000000000 +0000
@@ -101,7 +101,6 @@ int install_file_pte(struct mm_struct *m
{
int err = -ENOMEM;
pte_t *pte;
- pte_t pte_val;
spinlock_t *ptl;

pte = get_locked_pte(mm, addr, &ptl);
@@ -114,7 +113,6 @@ int install_file_pte(struct mm_struct *m
}

set_pte_at(mm, addr, pte, pgoff_to_pte(pgoff));
- pte_val = *pte;
/*
* We don't need to run update_mmu_cache() here because the "file pte"
* being installed by install_file_pte() is not a real pte - it's a
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-11-28 19:05    [W:0.026 / U:3.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site